Closed gabrielenava closed 4 years ago
cc @diegoferigo
Sadly, the changes from this PR https://github.com/robotology/codyco-modules/pull/280 was not carried over during the migration of the device from codyco-modules https://github.com/robotology/whole-body-estimators/pull/16 and I had missed this criticality in the review.
A pull request has been opened.
This was fixed in https://github.com/robotology/whole-body-estimators/pull/56.
@gabrielenava you can close this issue when you have tested the fix on your local machine.
@gabrielenava friendly ping! If you will not test this, I will close the issue, because I tested it on my local machine.
@gabrielenava friendly ping! If you will not test this, I will close the issue, because I tested it on my local machine.
I will test it, my deadline is tomorrow so I can clean up my laptop configuration (it is a bit messy in these days) and I'll be sure the test is consistent.
Sorry for the delay, the test was easy but my local configuration was really messy. I had to clean my superbuild and reinstall it to be sure my test was consistent.
Now that I have a clean and up-to-date superbuild, I tested the fix with iCubGenovaV2_5
, and it works with no issue! Thanks @prashanthr05!
Thank you @gabrielenava. Closing this issue.
After I wiped out the
robotology-superbuild
and reinstalled everything from zero, the problem I pointed out in https://github.com/robotology/codyco-modules/issues/277 happened again.To recap:
This fix allowed me to run the file: