search

robotology / whole-body-estimators

YARP devices that implement estimators for humanoid robots.
26 stars 12 forks source link

Add fail-fast strategy to C++CI workflow #52

Closed prashanthr05 closed 4 years ago

prashanthr05 commented 4 years ago

This helps avoid canceling other OS builds when one of the builds fail.

See https://github.com/robotology/whole-body-estimators/pull/45#issuecomment-602619220

It stopped the others because Windows failed. Is there a way to allow it to check it anyway?

According to this answer, this is due to a fail-fast behavior and by default it is set to true. I will open a PR.

prashanthr05 commented 4 years ago

Not sure, why it added two additional commits? ;D I had done a git pull on devel and branched out of it.

prashanthr05 commented 4 years ago

The reason why Windows failed is described in https://github.com/robotology/whole-body-estimators/pull/45#issuecomment-602624564 and relevant links.

Anyways this is a perfect test for the addition of fail-fast strategy. Looks like the test passed.

prashanthr05 commented 4 years ago

I will go ahead and merge this PR. The Windows related vcpkg error will be handled in a new PR.