robotology / whole-body-estimators

YARP devices that implement estimators for humanoid robots.
26 stars 12 forks source link

[devices][wholeBodyDynamics] replicate codyco-modules PR #280 Restore compatibility with YARP 3.2.0 #56

Closed prashanthr05 closed 4 years ago

prashanthr05 commented 4 years ago

Please see https://github.com/robotology/codyco-modules/pull/280 Restore compatibility with YARP 3.2.0 for the original PR and related issue.

This PR adds changes to launch-wholebodydynamics-*.xml configuration files.

traversaro commented 4 years ago

I thought I just copied the files directly from codyco-modules, let's hope there are not more of this problems.

prashanthr05 commented 4 years ago

I thought I just copied the files directly from codyco-modules, let's hope there are not more of this problems.

https://github.com/robotology/whole-body-estimators/issues/51#issuecomment-607710271 I missed it in review as well.

Probably if we restore the add-wbd branch and look at the graph comparing it with the latest master of codyco-modules, we can understand if we missed something?

prashanthr05 commented 4 years ago

@traversaro I can proceed with the merge, right? These changes are working for me in simulation.

traversaro commented 4 years ago

@traversaro I can proceed with the merge, right? These changes are working for me in simulation.

Yes, as you have to approval I guess it is ok to merge.

traversaro commented 4 years ago

Ah, I forgot two thins:

prashanthr05 commented 4 years ago

Ah, I forgot two thins:

Oops, I was wondering the same. I need to get used to this.

For now, I will add the changelog to devel and merge devel into master.