Closed prashanthr05 closed 4 years ago
I thought I just copied the files directly from codyco-modules, let's hope there are not more of this problems.
I thought I just copied the files directly from codyco-modules, let's hope there are not more of this problems.
https://github.com/robotology/whole-body-estimators/issues/51#issuecomment-607710271 I missed it in review as well.
Probably if we restore the add-wbd
branch and look at the graph comparing it with the latest master
of codyco-modules, we can understand if we missed something?
@traversaro I can proceed with the merge, right? These changes are working for me in simulation.
@traversaro I can proceed with the merge, right? These changes are working for me in simulation.
Yes, as you have to approval I guess it is ok to merge.
Ah, I forgot two thins:
Ah, I forgot two thins:
- In general the usual workflow is that bug fixes of critical issues go in master, and get forward merged in devel later
- you may want to add a line on https://github.com/robotology/whole-body-estimators/blob/master/CHANGELOG.md to document this bug fixes, but you can also do it later
Oops, I was wondering the same. I need to get used to this.
For now, I will add the changelog to devel and merge devel into master.
Please see https://github.com/robotology/codyco-modules/pull/280 Restore compatibility with YARP 3.2.0 for the original PR and related issue.
This PR adds changes to launch-wholebodydynamics-*.xml configuration files.