Closed prashanthr05 closed 4 years ago
The change seems ok, but there are some LockGuard.h inclusion that can also been removed?
The change seems ok, but there are some LockGuard.h inclusion that can also been removed?
I rebased over the latest devel and force pushed some additional changes related to LockGuard and ConstString specifications in wholebodydynamics
, genericSensorClient
and baseEstimatorV1
.
The changes make sense. But could you add info about the deprecation? I imagine there were some Pr or commit or message in idyntree and/or yarp. That way it would be possible to double check you didn't miss anything else that needs deprecation or change.
The changes make sense. But could you add info about the deprecation? I imagine there were some Pr or commit or message in idyntree and/or yarp. That way it would be possible to double check you didn't miss anything else that needs deprecation or change.
Here I have only addressed the deprecation warnings that popped up when compiling the repository. I didn't actually look into a specific issue or commit. Also, I have addressed only a few from the source code. We also would have to handle the CMake deprecations introduced by these dependencies.
If we look at the Release notes of YARP,
Additionally some CMake deprecations were introduced in YARP 3.0 itself. (unaddressed)
I will proceed with the merge. Let's open a new issue to handle the deprecations from all the dependencies and connect it to the epic #41
This PR addresses the following changes in wholebodydynamics device,
wholebodydynamics
,genericSensorClient
andbaseEstimatorV1
. Fixes #57