search

robotology / whole-body-estimators

YARP devices that implement estimators for humanoid robots.
26 stars 12 forks source link

[devices][wholebodydynamics] fix hardcoded low pass filter parameters #63

Closed prashanthr05 closed 4 years ago

prashanthr05 commented 4 years ago

Fixes #53

prashanthr05 commented 4 years ago

Oh, bug-fixes can be addressed to master right? Should I redirect the PR to master?

traversaro commented 4 years ago

Oh, bug-fixes can be addressed to master right? Should I redirect the PR to master?

As you prefer, especially if we have frequent release it is not a big problem if bug fixes go to devel .

traversaro commented 4 years ago

Oh, bug-fixes can be addressed to master right? Should I redirect the PR to master?

As you prefer, especially if we have frequent release it is not a big problem if bug fixes go to devel .

Even because this may be a bug fix, but it is also a breaking change over existing configuration files stored in robots-configuration https://github.com/robotology/robots-configuration/search?q=IDYNTREE_SKINDYNLIB_LINKS&unscoped_q=IDYNTREE_SKINDYNLIB_LINKS . It would be good if we also updated the configuration files there, or at least open an issue to do so.

prashanthr05 commented 4 years ago

Maybe we also update the changelog?

Done in https://github.com/robotology/whole-body-estimators/pull/63/commits/4c68686471643acc5cd0fa3fae2f76f4fc172619.

prashanthr05 commented 4 years ago

Oh, bug-fixes can be addressed to master right? Should I redirect the PR to master?

As you prefer, especially if we have frequent release it is not a big problem if bug fixes go to devel .

Even because this may be a bug fix, but it is also a breaking change over existing configuration files stored in robots-configuration https://github.com/robotology/robots-configuration/search?q=IDYNTREE_SKINDYNLIB_LINKS&unscoped_q=IDYNTREE_SKINDYNLIB_LINKS . It would be good if we also updated the configuration files there, or at least open an issue to do so.

I shall open a PR then.

prashanthr05 commented 4 years ago

Oh, bug-fixes can be addressed to master right? Should I redirect the PR to master?

As you prefer, especially if we have frequent release it is not a big problem if bug fixes go to devel .

Even because this may be a bug fix, but it is also a breaking change over existing configuration files stored in robots-configuration https://github.com/robotology/robots-configuration/search?q=IDYNTREE_SKINDYNLIB_LINKS&unscoped_q=IDYNTREE_SKINDYNLIB_LINKS . It would be good if we also updated the configuration files there, or at least open an issue to do so.

I shall open a PR then.

The relevant changes in configuration files were merged into robotology/robots-configuration.

Shall we merge this PR then?

traversaro commented 4 years ago

Ok for me!

prashanthr05 commented 4 years ago

Merged, thanks @traversaro @HosameldinMohamed !