Closed prashanthr05 closed 4 years ago
Oh, bug-fixes can be addressed to master right? Should I redirect the PR to master?
Oh, bug-fixes can be addressed to master right? Should I redirect the PR to master?
As you prefer, especially if we have frequent release it is not a big problem if bug fixes go to devel
.
Oh, bug-fixes can be addressed to master right? Should I redirect the PR to master?
As you prefer, especially if we have frequent release it is not a big problem if bug fixes go to
devel
.
Even because this may be a bug fix, but it is also a breaking change over existing configuration files stored in robots-configuration https://github.com/robotology/robots-configuration/search?q=IDYNTREE_SKINDYNLIB_LINKS&unscoped_q=IDYNTREE_SKINDYNLIB_LINKS . It would be good if we also updated the configuration files there, or at least open an issue to do so.
Maybe we also update the changelog?
Oh, bug-fixes can be addressed to master right? Should I redirect the PR to master?
As you prefer, especially if we have frequent release it is not a big problem if bug fixes go to
devel
.Even because this may be a bug fix, but it is also a breaking change over existing configuration files stored in robots-configuration https://github.com/robotology/robots-configuration/search?q=IDYNTREE_SKINDYNLIB_LINKS&unscoped_q=IDYNTREE_SKINDYNLIB_LINKS . It would be good if we also updated the configuration files there, or at least open an issue to do so.
I shall open a PR then.
Oh, bug-fixes can be addressed to master right? Should I redirect the PR to master?
As you prefer, especially if we have frequent release it is not a big problem if bug fixes go to
devel
.Even because this may be a bug fix, but it is also a breaking change over existing configuration files stored in robots-configuration https://github.com/robotology/robots-configuration/search?q=IDYNTREE_SKINDYNLIB_LINKS&unscoped_q=IDYNTREE_SKINDYNLIB_LINKS . It would be good if we also updated the configuration files there, or at least open an issue to do so.
I shall open a PR then.
The relevant changes in configuration files were merged into robotology/robots-configuration.
Shall we merge this PR then?
Ok for me!
Merged, thanks @traversaro @HosameldinMohamed !
Fixes #53