robotology / whole-body-estimators

YARP devices that implement estimators for humanoid robots.
26 stars 12 forks source link

Wrong CMake variable replacement #78

Closed diegoferigo closed 4 years ago

diegoferigo commented 4 years ago

In the CMake files of the yarprobotinterface's xml file I can see that few variables should be replaced, such as:

https://github.com/robotology/whole-body-estimators/blob/38dc6a269f1b0bce09f31d8ae9c4ca3602e8e46b/devices/wholeBodyDynamics/app/CMakeLists.txt#L32-L34

However, the xml files have a wrong variable and it is not actually substituted by configure_file. In fact, the following

https://github.com/robotology/whole-body-estimators/blob/38dc6a269f1b0bce09f31d8ae9c4ca3602e8e46b/devices/wholeBodyDynamics/app/launch-wholebodydynamics-icub-six-fts-sim.xml#L4

should instead contain @WBD_YARP_ROBOT_NAME@.

cc @prashanthr05 @HosameldinMohamed @traversaro