Closed HosameldinMohamed closed 3 years ago
Comment from @prashanthr05 https://github.com/robotology/whole-body-estimators/pull/58#issuecomment-608297683:
If we look at the Release notes of YARP,
The Mutex related classes are deprecated with YARP 3.3 (addressed) There is a deprecation of Vocab in YARP 3.1 which was also showing up during compilation. But this was related to autogenerated idl files. I didnt know how to handle this. Additionally some CMake deprecations were introduced in YARP 3.0 itself. (unaddressed)
Some comments:
YARP_INCLUDE_DIRS
can be dropped, as now that is handled by CMake's imported targetsYARP_MODULE_PATH
can be dropped, as the path is automatically updated when you do find_package(YARP)
find_package(YARP)
project
call in ctrlLibRT
can be removed.wholeBodyDynamicsHelpers
seem to be empty. They can also be removed.
- Use of
YARP_INCLUDE_DIRS
can be dropped, as now that is handled by CMake's imported targets- Use of
YARP_MODULE_PATH
can be dropped, as the path is automatically updated when you dofind_package(YARP)
- If you use the idl component of YARP, remember to search for it in
find_package(YARP)
- The
project
call inctrlLibRT
can be removed.
Thanks. I opened PR #87.
- In libraries
wholeBodyDynamicsHelpers
seem to be empty. They can also be removed.
@prashanthr05 Maybe I can do that in a separate PR? to keep #87 clean?
- In libraries
wholeBodyDynamicsHelpers
seem to be empty. They can also be removed.@prashanthr05 Maybe I can do that in a separate PR? to keep #87 clean?
Thanks @HosameldinMohamed! Yes, this is indeed unrelated, even to this issue. My bad.
Shall we close this issue?
I think we can since the main goal of the issue is done.
When I configure in cmake I get the following warnings (latest commit a02678cca060aa524d14ca8bd0838c1ae5521bac in
devel
):