search

robotology / yarp-device-realsense2

realsense2 device for YARP (https://www.yarp.it/)
Other
8 stars 10 forks source link

updated plumb bob distortion #26

Closed ste93 closed 2 years ago

ste93 commented 2 years ago

since https://github.com/robotology/yarp/issues/2544 has been closed then we can do this fix? also related to https://github.com/robotology/yarp-device-realsense2/issues/10, maybe is better to put distortion none?

ste93 commented 2 years ago

@traversaro fyi

traversaro commented 2 years ago

since robotology/yarp#2544 has been closed then we can do this fix?

Ok for me, I just suggest to also bump the required YARP version in https://github.com/robotology/yarp-device-realsense2/blob/master/CMakeLists.txt#L53 and add a line to the changelog?

traversaro commented 2 years ago

also related to #10, maybe is better to put distortion none?

Replying in #10 on this.

ste93 commented 2 years ago

as said in #10 updated in order to have distortion none

traversaro commented 2 years ago

@ste93 I revised the CHANGELOG, feel free to check it out for the future.