Avoid dereferencing null ptr on optional arg, add .gitignore

robotology / yarp-device-realsense2

realsense2 device for YARP (https://www.yarp.it/)

Other

7 stars 10 forks source link

Avoid dereferencing null ptr on optional arg, add .gitignore #4

Closed PeterBowman closed 3 years ago

PeterBowman commented 3 years ago

Not much to add here, I ran into this bug while trying to call IRGBDSensor::getRgbImage(image) or IRGBDSensor::getDepthImage(image) with no second optional parameter (pointer to timestamp, defaulted to NULL).

Also adding .gitignore with targeted build folder and Eclipse/VScode IDE-related stuff.

PeterBowman commented 3 years ago

Shall I duplicate this PR on the main YARP repo, which still stores a copy of this code in the yarp-3.4 branch?

traversaro commented 3 years ago

Thanks a lot @PeterBowman for the PR.

Shall I duplicate this PR on the main YARP repo, which still stores a copy of this code in the yarp-3.4 branch?

The plan is to eventually remove the device from YARP, but I guess that @drdanz may be interested in this fix for patch releases of the 3.4 series.

drdanz commented 3 years ago

Merged, thanks.

drdanz commented 3 years ago

Done, see robotology/yarp@2a2a567320d2f93fdb3590995b02f56dac737e6b Thanks @PeterBowman