search

robotology / yarp-devices-ros2

Plugins, devices and network wrappers for Yarp-ROS2 interoperation
http://www.yarp.it
10 stars 9 forks source link

Add support for building map2D_nws_ros2 as part of the main CMake project #10

Closed traversaro closed 3 years ago

traversaro commented 3 years ago

Fix https://github.com/robotology-playground/yarp-ros2/issues/6 . For the time being I added this modification behind an option YARP_ROS2_USE_SYSTEM_map2d_nws_ros2_msgs, whose default value is ON, so the default behaviour does not change. The main use case for this modification is to eventually include this repository in the robotology-superbuild, where by the way the AMENT_PREFIX_PATH value is already set: https://github.com/robotology/robotology-superbuild/blob/master/cmake/template/setup.sh.in#L28 .

traversaro commented 3 years ago

fyi @drdanz @ahoarau

drdanz commented 3 years ago

I believe that after some testing, if this works, we can remove the YARP_ROS2_USE_SYSTEM_map2d_nws_ros2_msgs and just use the "regular" CMake behaviour

traversaro commented 3 years ago

I believe that after some testing, if this works, we can remove the YARP_ROS2_USE_SYSTEM_map2d_nws_ros2_msgs and just use the "regular" CMake behaviour

Yes, this could make sense. Note that it is still perfectly possible to have the yarp-ros2 repo as an whole as a project in a colcon workspace.