Enable Windows in CI - Githubissues

robotology / yarp-devices-ros2

Plugins, devices and network wrappers for Yarp-ROS2 interoperation

http://www.yarp.it

10 stars 10 forks source link

Closed traversaro closed 2 years ago

traversaro commented 2 years ago

To fix Windows compilation on ROS Humble, this PR:

Adds #define _USE_MATH_DEFINES to permit to use M_PI,
Switch to use BUILD_SHARED_LIBS set to ON by default. This is not strictly necessary, but it is done to workaround a bug in rosidl_typesupport_fastrtps_cpp and rosidl_typesupport_fastrtps_c on ROS Humble when when BUILD_SHARED_LIBS is set to OFF, see https://github.com/RoboStack/ros-humble/issues/1 .

traversaro commented 2 years ago

traversaro commented 2 years ago

The PR is ready for review. @ste93 @randaz81