robotology / yarp-devices-ros2

Plugins, devices and network wrappers for Yarp-ROS2 interoperation
http://www.yarp.it
10 stars 10 forks source link

Fixes for Imu_nws_ros2 to have imu output on ros2 coherent with the one in YARP #72

Closed kaidegast closed 2 months ago

kaidegast commented 2 months ago

Changes:

  1. Set values of quaternion after vecrpy has been initialized.
  2. Fix typo where quat component w was assigned to orientation component z.

With the proposed changes the orientation fields are now correctly populated image image

When converted to euler angles, we can ascertain the conformity to the imu data provided by YARP shown below:

yarp read ... */imu/measures:o ... (((0.99173901418694421217 -0.176201742695876545364 -0.339108696240359386298) 930.100999999999999091)) (((2.86410118451818229701 -0.0548334604433729569384 -9.32010341306919087856) 930.100999999999999091)) (((0.0 0.0 0.0) 930.100999999999999091)) (((-179.986989286195182558 -17.2129761567645758191 -139.609585520027223993) 930.100999999999999091)) ...

@traversaro @Nicogene @randaz81

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

traversaro commented 2 months ago

Thanks @kaidegast !