robotology / yarp

YARP - Yet Another Robot Platform
http://www.yarp.it
Other
529 stars 195 forks source link

Fix for portaudioRecorder, portaudioPlayer device ID selection #3143

Closed randaz81 closed 1 month ago

randaz81 commented 1 month ago

Replaced parameter "id" in portaudioPlayer, portaudioRecorder with "a…udio_device_id" because "id" and "device_id" are keywords reserved by yarprobotinterface. Additionally a new print now shows the name of the selected interface.

update-docs[bot] commented 1 month ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

traversaro commented 1 month ago

fyi @S-Dafarra @mebbaid @GiulioRomualdi @giotherobot @carloscp3009

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
7.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

codacy-production[bot] commented 1 month ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +35.99% :white_check_mark: 0.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (1a16d4b8b73f83cc75e99d1c89136537655e0650) | 425225 | 79401 | 18.67% | | | Head commit (1d3848801f1c545fbf7637e2bec8344802d9f533) | 112299 (-312926) | 61391 (-18010) | 54.67% (**+35.99%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#3143) | 15 | 0 | **0.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more