robotology / ycm-cmake-modules

YCM (YCM CMake modules) is a collection of various useful CMake modules.
http://robotology.github.io/ycm-cmake-modules
Other
50 stars 22 forks source link

FindOpenCV: Fix arguments passed to find_package_handle_standard_args #449

Closed traversaro closed 3 months ago

traversaro commented 3 months ago

OpenCV_CONFIG is not a variable set, so I have no idea why this was working without giving an error:

 Could NOT find OpenCV (missing: OpenCV_CONFIG)

as it is happening in https://github.com/icub-tech-iit/ergocub-software/issues/248 .

traversaro commented 3 months ago

Apparently this is still not working on @S-Dafarra system, I need to understand more about it. @Nicogene can we wait at least monday for the distro release? I would like to fix this.

Nicogene commented 3 months ago

@traversaro sure no problem!

traversaro commented 3 months ago

I was unable to reproduce @S-Dafarra's problem on my PC, both the one before this PR and after this PR. For this reason, let's at least merge this PR, that fixes the clear problem of the use of the undefined OpenCV_CONFIG CMake variable.