robotology / ycm-cmake-modules

YCM (YCM CMake modules) is a collection of various useful CMake modules.
http://robotology.github.io/ycm-cmake-modules
Other
50 stars 23 forks source link

YCMDefaultDirs should be deprecated #83

Closed traversaro closed 5 years ago

traversaro commented 9 years ago

I recently cleanup up the cmake of iDynTree, and I simplified them a bit removing all references to the variable defined by YCMDefaultDirs. Apparently its use is also advocated in our examples (see https://github.com/tacman-fp7/template-pkg) but what aim does this module fulfill?

drdanz commented 5 years ago

I'd like to get rid of the file, but unfortunately it seems to be used in several places: https://github.com/search?q=YCMDefaultDirs&type=Code

Perhaps we should deprecate it and remove it in a second moment?

traversaro commented 5 years ago

Perhaps we should deprecate it and remove it in a second moment?

I agree.

drdanz commented 5 years ago

Renaming issue.

drdanz commented 5 years ago

Fixed by #234