robotools / extractor

Tools for extracting data from font binaries into UFO objects.
MIT License
51 stars 16 forks source link

Extract TrueType instructions to TTX assembly format #30

Closed jenskutilek closed 3 years ago

jenskutilek commented 4 years ago

Just keeping track of my experiments here ... related discussion: https://github.com/unified-font-object/ufo-spec/issues/93

jenskutilek commented 4 years ago

I have changed the code so the extracted TrueType programs are in FontTools TTX assembly format.

The PR depends on https://github.com/fonttools/fonttools/pull/2005, that's why the checks fail.

jenskutilek commented 4 years ago

The checks fail because of Py3-only syntax. Is Python 2.7 support still a concern for extractor?

typemytype commented 4 years ago

Nope, py 2.7 can be removed. Maybe in a different PR which you can pull into this PR

jenskutilek commented 3 years ago

I think this is ready to be merged. Should we wait until the UFO spec (https://github.com/unified-font-object/ufo-spec/pull/94) has been officially updated?

benkiel commented 3 years ago

@jenskutilek Spec has been updated, merging.

jenskutilek commented 3 years ago

Thank you!

moyogo commented 3 years ago

@jenskutilek @benkiel The component flags (round, useMyMetrics, overlap) are not part of the UFO public.truetype.instructions spec. See https://github.com/unified-font-object/ufo-spec/issues/162

jenskutilek commented 3 years ago

I've disabled extraction of composite flags for now: #32

moyogo commented 3 years ago

Thanks @jenskutilek. Sorry for the trouble.