search

robotools / fontParts

The replacement for RoboFab
MIT License
133 stars 44 forks source link

`.autoContourOrder()` raises `NotImplementedError` #645

Closed roberto-arista closed 2 years ago

roberto-arista commented 2 years ago

hey all!

I've recently noticed that .autoContourOrder() is not implemented in fontshell: https://github.com/robotools/fontParts/blob/master/Lib/fontParts/base/glyph.py#L1502-L1520

I would like to give it a try!

The comment says that the code might be ported from RoboFab, and I assume the starting point would be this method: https://github.com/robotools/robofab/blob/2ea0b6201cf67be866f6b6afa9574ef7219fd140/Lib/robofab/objects/objectsBase.py#L1616-L1650

Is the contour order explained in the RoboFab method still valid?

👋

benkiel commented 2 years ago

Yes and yes

roberto-arista commented 2 years ago

great, I am on it

benkiel commented 2 years ago

Fixed by #646