Implement type checking with github actions

robotools / fontParts

The replacement for RoboFab

MIT License

136 stars 44 forks source link

Implement type checking with github actions #775

Open roberto-arista opened 4 days ago

roberto-arista commented 4 days ago

Hey @benkiel and @knutnergaard,

I took a quick look into this and have a couple of questions:

Should I continue working on the v1 branch?
Should the checks be implemented using tox?
@knutnergaard, did you use mypy or pyright when updating the code? I ran a quick scan of the v1 codebase with mypy error highlighting and noticed several issues.

Looking forward to your input! 👋

knutnergaard commented 4 days ago

@roberto-arista

I used mypy when updating the code and reported the issues which I was unable to solve in #739, but these are, at least for the most part, related to conflicts with the base.py module.

roberto-arista commented 4 days ago

If these can't be solved and we want to implement type checking in CI, we need to flag each of them with # type: ignore. Do you see other options?

knutnergaard commented 4 days ago

No, I agree, but I think these errors can be solved. I'm just not comfortable making adjustments to the base module logic without a second opinion from someone with more intimate knowledge of the codebase.

We could make a list of all unique errors in the annotated modules, and make a PR to solve them.

benkiel commented 4 days ago

@roberto-arista Yes, keep to the v1 branch, and yes have tox run the checking