Fix import FontInfo from fonttools

robotools / robofab

RoboFab

http://robofab.org

Other

108 stars 31 forks source link

Fix import FontInfo from fonttools #29

Closed behdad closed 9 years ago

behdad commented 9 years ago

Many bug fixes in this function:

Rename from deprecated fontStyle to styleMapStyleName,
Fix OpenType nameID for fontStyle; was 1, should be 2,
Lowercase style name such that "Regular" is accepted,
Request English names, otherwise we get arbitrary language,
Correctly decode strings as UTF-16BE, not UTF-16,
Improve error reporting.

It's not perfect, but at least loads regular fonts without error.

LettError commented 9 years ago

Does this pull make robofab dependent on a specific fork of FontTools?

behdad commented 9 years ago

I don't think so. The only fonttools-related change is passing language down to getName(), which exists in JvR's fonttools. The rest are genuine robofab fixes.

behdad commented 9 years ago

Ping. :)