search

robotools / vanilla

A Pythonic wrapper around Cocoa.
MIT License
78 stars 28 forks source link

VerticalStackView edgeInsets order? #140

Closed roberto-arista closed 3 years ago

roberto-arista commented 3 years ago

👋

I was trying to make a pull request to better specify the edgeInsets attribute on the VerticalStackView, but I have a "mixed" feedback from my tests on Robofont.

Here's a quote from the docstring

edgeInsets Tuple of four numbers indicating the amount to inset the views.

How are they supposed to be ordered? (top, bottom...)

typesupply commented 3 years ago

It follows the order defined in NSEdgeInsets: (bottom, left, right, top). I should have made it (left, top, right, bottom) like the posSize, but I didn't for some reason. You could change it if you want to to make the documentation clearer. I don't think much is using this yet. Here's where the change would happen:

https://github.com/robotools/vanilla/blob/master/Lib/vanilla/vanillaStackView.py#L125

roberto-arista commented 3 years ago

done!

https://github.com/robotools/vanilla/pull/141

typesupply commented 3 years ago

Merged. Thanks!