search

robotools / vanilla

A Pythonic wrapper around Cocoa.
MIT License
78 stars 28 forks source link

remove deprecated code without extra dependency #170

Closed schriftgestalt closed 2 years ago

schriftgestalt commented 2 years ago

It would be great if that could be merge as soon as possible. I’m getting a lot crash reports because of this.

justvanrossum commented 2 years ago

Note that we have releases on PyPI and release tags: https://github.com/robotools/vanilla/tags.

You should not install directly from the head of the repo.

schriftgestalt commented 2 years ago

But Glyphs does manage (install and update) all plugins using git. Using pip (and PyPI) would be much works for all those plugins and the tags for vanilla are from last year, so not really up to date.

I would consider the main branch of any repo to be stable to use for regular users. Maybe do commits like this on a dev branch?

justvanrossum commented 2 years ago

No, only release tags are considered stable.

Do you also install (for example) fonttools from the head of the repo?

justvanrossum commented 2 years ago

Btw. the real bug is that packaging isn't declared as a dependency in setup.py. But I bet that wouldn't have helped the Glyphs problem, given you don't appear to use pip at all. You really should!

Frederik is currently travelling, and I'm not going to merge this without his review.

schriftgestalt commented 2 years ago

I better understand the intended behavior now and will find a solution. I probably will point Glyphs to a fork that I can control.

justvanrossum commented 2 years ago

Tip: DrawBot contains a pip installer with GUI, but that code can also be used as an example of how to use pip programmatically: https://github.com/typemytype/drawbot/blob/master/drawBot/pipInstaller.py

benkiel commented 2 years ago

I am ok with this change.

typemytype commented 2 years ago

thanks Georg!