search

robotools / vanilla

A Pythonic wrapper around Cocoa.
MIT License
78 stars 28 forks source link

Remove hasattr test in _alertBindings. #179

Closed typesupply closed 1 year ago

typesupply commented 1 year ago

This is for #178.

typesupply commented 1 year ago

@typemytype Whenever you have a chance, could you review this? I think it's fine but want a review since it will effect all window events, notably whenever a window is moved or resized.

typemytype commented 1 year ago

during windowWillClose_ the hasattr also be removed, I guess. Its not possible to close a window twice anyhow.

typesupply commented 1 year ago

Fixed. I moved the destruction of _bindings into _breakCycles.