robotopia-x / robotopia

:robot: Introducing kids to coding with tiny virtual robots!
https://robotopia-x.github.io/
MIT License
512 stars 56 forks source link

Starting signalhub-server internal #135

Open stritti opened 6 years ago

stritti commented 6 years ago

For local installation it would be cool to add possibility to start the hub internal. something like:

var hub = signalhub('robotopia', [
  P2P_CONFIG.habUrl
])
timgrossmann commented 6 years ago

@stritti Just to make sure I understand this right.

Instead of the provided SignalHub server you want to run Robotopia locally and use your own SignalHub server instead of the provided on.

If it's the case that you want to run it locally anyway you can simply edit this: https://github.com/robotopia-x/robotopia/blob/38e43f1d546aafacfad8a121cea2e1fd3d050ac7/index.js#L1-L4

And build and start it on your own system.

If this is not what you meant, feel free to open this issue again. Thank you

stritti commented 6 years ago

Hi @timgrossmann thanks for the pointer. I found this,

The base issue was, that you will receive a CORS-Exception if you run the project locally (also on robotopia.co) using existing hub. See console of browser if you run presenter mode: http://robotopia.co/#presenter ->

No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://robotopia.co' is therefore not allowed access. The response had HTTP status code 403.

To get a easy setup to run, I thought it could be a good idea to add the hub internally.

BTW, I switched for now to https://signalhub-jccqtwhdwc.now.sh/, which works for me for the moment.