robototes / Crescendo2024

Other
8 stars 13 forks source link

Commands missing meaningful names #106

Open jamesdooley4 opened 3 months ago

jamesdooley4 commented 3 months ago

I was looking at lots trying to diagnose an issue with the launcher being unexpectedly told to quickly slow down (causing a temperature spike), but can't tell which commands are being run since several use the same generic names "RunCommand" and "ParallelRaceGroup". This should be simply fixable by appending .withName(), such as:

driveController.rightStick().onTrue(new InstantCommand(s.drivebaseSubsystem::toggleXWheels).withName("ToggleXWheels"));

or

Commands.race(new RumbleCommand(controls), new WaitCommand(1)).withName("SetAngleLaunchCompletedRumble").schedule();

image