Closed adam-patterson closed 10 years ago
Looks good once exception is moved here.
Any exception caused by a failed connection attempt is already handled in the _instance
function. The call to the constructor will throw a PDOException
if the attempt to connect to the requested database fails. This is then caught and rethrown wrapped in our own exception.
In the case where the instance is null when the function is called, it would just make the connection.
I will change the exception throwing in the two core classes to use asserts instead.
:+1:
... existing instance
@robotpony