search

robotpy / examples

Repository of RobotPy example projects
43 stars 52 forks source link

Add AprilTagVision example #100

Closed Suave101 closed 8 months ago

Suave101 commented 8 months ago

A task within issue #49. This is a port of the Java AprilTagsVision example to Python

Suave101 commented 8 months ago

This is a Draft pull request for a couple of reasons:

  1. This is my first pull request and I am not sure if all the formatting is perfect
  2. I have tested this code but, I am not confident in my test due to the following quote from the robotpy documentation:

"The child process will NOT be launched when running the robot code in simulation or unit testing mode", RobotPy Documentation

Suave101 commented 8 months ago

A test of the vision.py file has been conducted and bugs were found. The bugs were subsequently fixed and code reformatted into black. The robot.py file has been changed to lowercase and the comment at the beginning of the robot.py has been changed to a docstring!

Suave101 commented 8 months ago

The following workflow does not allow the first line of vision.py to be #!/usr/bin/env python3: https://github.com/robotpy/examples/actions/runs/7383683670/job/20099069304 The following commit changed the vision.py to meet the conventions of the workflow: https://github.com/robotpy/examples/pull/100/commits/75b30b70e3258e4b417d471e6a9a887c19f9b6fc

Suave101 commented 8 months ago

Could someone please help me fix what is causing the failure in checks?

auscompgeek commented 8 months ago

The new robot is missing from run_tests.sh.

virtuald commented 8 months ago

Please rebase and remove wpilib.run (see https://github.com/robotpy/examples/pull/106)

Suave101 commented 8 months ago

Closing for Rebase

virtuald commented 8 months ago

When you rebase, you can force push your branch that way you don't have to recreate the PR.