search

robotpy / examples

Repository of RobotPy example projects
45 stars 53 forks source link

Frisbeebot example #58

Closed BerkeSinanYetkin closed 1 year ago

BerkeSinanYetkin commented 1 year ago

extension of #56, as you can't change which branch you want to merge from on a ongoing pr.

BerkeSinanYetkin commented 1 year ago

@virtuald should i add the frisbeebot example to ignored tests? It works as intended in simulation but setDistancePerPulse fails the test even though it seems like nothing has changed from 2022.

virtuald commented 1 year ago

Let me take a look locally.

virtuald commented 1 year ago

The problem is that all of your motors/encoders are initialized at the class level instead of in __init__. I'll see if I can make pyfrc give a better error message when that happens.

virtuald commented 1 year ago

I'm going to go ahead and fix this locally, adjust some of the style to match python better, and push a new PR using the fixes in a few minutes. Thanks!

virtuald commented 1 year ago

Closed in favor of #59