search

robotpy / examples

Repository of RobotPy example projects
45 stars 53 forks source link

add CANPDP example #86

Closed fletch3555 closed 11 months ago

fletch3555 commented 11 months ago

Grabbing some low-hanging fruit

virtuald commented 11 months ago

It would be best if you could run the example in simulation in the future to catch errors. Thanks for the contribution.

fletch3555 commented 11 months ago

It would be best if you could run the example in simulation in the future to catch errors. Thanks for the contribution.

What was the issue?

virtuald commented 11 months ago

All of the functions were capitalized, like SmartDashboard.PutNumber. RobotPy follows the Java conventions, not the C++ conventions, despite being based on the C++ codebase.

fletch3555 commented 11 months ago

All of the functions were capitalized, like SmartDashboard.PutNumber. RobotPy follows the Java conventions, not the C++ conventions, despite being based on the C++ codebase.

Ah whoops. Copy/paste error. I fixed that in the others but I guess I missed it here. Thanks for the fix!