robotpy / examples

Repository of RobotPy example projects
43 stars 52 forks source link

low hanging fruit #91

Closed fletch3555 closed 9 months ago

fletch3555 commented 9 months ago

Some new examples:

Also reformated/updated a few existing ones to be more consistent with java examples

fletch3555 commented 9 months ago

It's becoming more apparent as I look through more and more of these examples, that there's a few different styles at play. I've been creating class-level constants with all-caps snakecase, but I see others following the k-prefix camelcase style. There are also a few others that define them in robotInit() instead of the class itself.

Is there a specific style you'd prefer to follow? I know the k-prefix is commonly used elsewhere in wpilib, but I've found the all-caps style to be more common in my professional experience. That said, I don't hold any strong opinions here. I'm happy to go update the ones I've already done.

virtuald commented 9 months ago

Generally we follow the Java wpilib conventions, which uses k-prefix style. I don't care that much about which it is.

fletch3555 commented 9 months ago

I'll stop adding to this so it can be properly reviewed. All the checks are green, so should be good to go now.