search

robotpy / mostrobotpy

Official Repository of python implementation of WPILib components
https://robotpy.github.io
Other
10 stars 11 forks source link

ntcore: TimestampedRaw should provide bytes, not list[int] #45

Closed auscompgeek closed 9 months ago

auscompgeek commented 9 months ago

Mentioned in passing by Photonvision folks, but I don't know any of the details.

Inherited from how NT4 returns the raw bytes topic value

_Originally posted by @gerth2 in https://github.com/PhotonVision/photonvision/pull/1040#discussion_r1423366787_

virtuald commented 9 months ago

I just tried it by modifying the simple_*.py examples to getRaw/setRaw and this isn't the case, it returns bytes. Closing unless there's a reproducer.

gerth2 commented 9 months ago

image ntcore 2024.0.0b3.post1 - TimestampedRaw is typehinted to lists of ints, not bytes

gerth2 commented 9 months ago

At runtime on a roboRIO - looks like the type does indeed come back as int - image