robotpy / pyfrc

python3 library designed to make developing RobotPy-based code easier!
MIT License
50 stars 35 forks source link

[BUG]: slow deploy #204

Closed virtuald closed 7 months ago

virtuald commented 2 years ago

Problem description

@TheTripleV reports using this fixed their slow deploy issues:

sock = socket.socket(socket.AddressFamily.AF_INET, socket.SOCK_STREAM)

retry_on_signal (lambda: sock.connect((self.hostname, 22)))
self.client.connect(
  self.hostname,
  username=self.username,
  password=self.password,
  allow_agent=False,
  look _for_keys-False,
  sock=sock,
)

TBH, probably should add the retry_on_signal to RobotFinder and just reuse that socket instead of making a second connection?

Operating System

Windows

Installed Python Packages

No response

Reproducible example code

No response

TheTripleV commented 2 years ago

Netconsole also has this issue.

virtuald commented 1 year ago

I'm surprised this is an issue in newer pythons because of https://peps.python.org/pep-0475/