robotpy / pyfrc

python3 library designed to make developing RobotPy-based code easier!
MIT License
50 stars 35 forks source link

Add mypy or pyright checker on deploy #206

Open virtuald opened 2 years ago

virtuald commented 2 years ago

Could help out teams not deploy bad code.

Mypy tends to have a lot of false positives, would need to ensure that any solution was either optional or not obnoxious when enabled.

auscompgeek commented 2 years ago

mypy took upwards of half a minute to run on my team's codebase last season in GitHub Actions. pyright was a lot faster, but also a fair bit more strict than mypy by default.