search

robotpy / pynetworktables

Pure python implementation of the FRC NetworkTables protocol
Other
60 stars 30 forks source link

Update rate does not match pyntcore #105

Open auscompgeek opened 4 years ago

auscompgeek commented 4 years ago

If pyntcore is installed, the default update rate will suddenly change, which I would expect nobody installing random packages would expect to happen. This also makes the docs inconsistent with pyntcore.

The following line needs to be changed to be every 100 ms instead:

https://github.com/robotpy/pynetworktables/blob/812e615d4e86858e5844ad9c1bc4015715f3bd76/_pynetworktables/_impl/dispatcher.py#L71

auscompgeek commented 4 years ago

In the meantime, if you would like your update rate to be consistent regardless of what packages are installed, you can use the NetworkTablesInstamce.setUpdateRate method.

Robot code always uses pyntcore, and so will always have a default update rate of 100 ms.

virtuald commented 4 years ago

I feel like we should change pyntcore's default to be 50ms?

auscompgeek commented 4 years ago

Given the performance issues we had last year, I'm not sure I'm comfortable with doubling down on the doubled update rate here.

auscompgeek commented 2 years ago

Well, it's almost 2022. Which way do we want to go? I'm still in favour of matching ntcore here.

virtuald commented 2 years ago

FIne.