search

robotpy / pynetworktables

Pure python implementation of the FRC NetworkTables protocol
Other
60 stars 30 forks source link

add github actions testing #113

Closed TheTripleV closed 3 years ago

TheTripleV commented 3 years ago

Add tests on Github Actions. This PR tests both backends. The ntcore backend has failing tests so this will always fail for now.

virtuald commented 3 years ago

I feel if we're going to add github actions, let's remove travis?

TheTripleV commented 3 years ago

I agree. I've left out pushing to pypi so far. Are the pypi secrets in this repo?

auscompgeek commented 3 years ago

Could we also run the pure Python and pyntcore tests in parallel please?

TheTripleV commented 3 years ago

Could we also run the pure Python and pyntcore tests in parallel please?

Done. Example run: https://github.com/TheTripleV/pynetworktables/runs/896761369?check_suite_focus=true

virtuald commented 3 years ago

Is this good to go? Might be worth using some of the github actions updates I'm pushing out.

TheTripleV commented 3 years ago

Yes. The CI is finished. The only thing left is that a few test cases fail on the ntcore backend: https://github.com/TheTripleV/pynetworktables/runs/934751015?check_suite_focus=true

TheTripleV commented 3 years ago

I guess we could use the build actions for building. They can't be used for testing because we need to install pyntcore from tortall here (until linux wheels can be downloaded from pypi).

auscompgeek commented 3 years ago

until linux wheels can be downloaded from pypi

I believe this is actually possible now, we just need to tag our wheels with an appropriate manylinux tag.

virtuald commented 3 years ago

It would be good to fix the tests.

I believe this is actually possible now, we just need to tag our wheels with an appropriate manylinux tag.

Have you done any experimentation with this sort of thing? It would be useful to know if we could do it.

virtuald commented 3 years ago

I guess we could use the build actions for building. They can't be used for testing because we need to install pyntcore from tortall here (until linux wheels can be downloaded from pypi).

I don't understand? The build actions I recently added do pull wheels from tortall?

TheTripleV commented 3 years ago

Ah. I'll switch over to using the build actions.

virtuald commented 3 years ago

I believe all of the secrets are setup correctly for this repo for the new build actions. The RTD webhook actions aren't necessary for this repo.

TheTripleV commented 3 years ago

Some steps now use robotpy build actions.

TheTripleV commented 3 years ago

I think the only reason I left this as draft was because of the failing pyntcore test and because the pure stuff is imported all over the place in the tests.

Since actions aren't available here, all pushes to this pr trigger actions here: https://github.com/TheTripleV/pynetworktables/actions