robotpy / pynetworktables

Pure python implementation of the FRC NetworkTables protocol
Other
60 stars 30 forks source link

Implement 2017 DS client connection support #53

Closed auscompgeek closed 6 years ago

auscompgeek commented 6 years ago

Note: I have not had a chance to test this. If a kind soul would be generous enough to test this with their driver station, I would seriously appreciate it.

Writing unit tests for this would probably be worthwhile too.

I don't have to touch anything else for this to work, right?

Fixes: #35

ArchdukeTim commented 6 years ago

I can test it. Lemme know how

auscompgeek commented 6 years ago

Basically, on your driver console laptop, fire up something that uses pynetworktables, make sure it starts the DS client, and fire up the DS.

I'll most likely add some unit tests once I get around to it too.

ArchdukeTim commented 6 years ago

Oh that mean i need python and git and everything on the DS laptop? Oh boy

virtuald commented 6 years ago

Technically, you could build a standalone pynetworktables2js executable and try it that way...

ArchdukeTim commented 6 years ago

Well I've got a DS here anyway

auscompgeek commented 6 years ago

So I still haven't gotten around to finishing this. But the basic idea for tests is this:

Then, do each of the following (separate tests):

Then check the relevant mock methods were called.

auscompgeek commented 6 years ago

Finally took the opportunity to rebase this and clean it up a bit. Still need to write tests (and also probably actually test it works with a real robot too).

virtuald commented 6 years ago

Tested on my real DS and it works. Thanks for this!