search

robotpy / pynetworktables2js

Forwards NetworkTables traffic to a web page, allowing you to write custom dashboards for your robot using HTML/Javascript
MIT License
46 stars 18 forks source link

Allow cbor2 versions above 5.0 #45

Open KenwoodFox opened 2 years ago

KenwoodFox commented 2 years ago

This is a fix for #44

Turns out the underlying issue in 44 comes from the older cbor2 version 4.9, i tested on python 3.10 with cbor2 version 5.4.2 and it seemed to work fine but im not sure if this would break older python versions.

sidharthmrao commented 1 year ago

Could someone please take a look at merging this PR? It works for me and is necessary for use in python3.10.

PeterJohnson commented 1 year ago

Note that this repo/tool is not needed with NetworkTables 4, which is websockets based and can be used directly from JavaScript.

sidharthmrao commented 1 year ago

Oh that's perfect, thank you.

KenwoodFox commented 1 year ago

Note that this repo/tool is not needed with NetworkTables 4, which is websockets based and can be used directly from JavaScript.

Oh that is great! I'll have to let my team know, atm if you do want to incude this change just drop the git link to this branch in your requirements or project pipfile or set the version back to 3.8 like this https://github.com/FRC-1721/1721-RapidReact/blob/a8ba43fd3ed713b8fc7e0688153e1a2970b03d00/dashboard/Pipfile#L12