robotpy / robotpy-ctre

RobotPy wrappers for CTRE Phoenix 5 library
Other
13 stars 21 forks source link

Update CTRE libraries #146

Closed virtuald closed 2 years ago

virtuald commented 2 years ago
auscompgeek commented 2 years ago

Hmm, I'm surprised we don't use py::overload_cast.

virtuald commented 2 years ago

I did at first, but it fails in certain cases that I no longer remember.

virtuald commented 2 years ago

Let's not merge until we see CTRE announce this, or that the library shows up on https://maven.ctr-electronics.com/release/com/ctre/phoenix/Phoenix-frc2022-latest.json, just in case there's an issue.

auscompgeek commented 2 years ago

... or it shows up on https://github.com/CrossTheRoadElec/Phoenix-Releases/releases

auscompgeek commented 2 years ago

Just got the GitHub notification from CTRE. Good to go?

virtuald commented 2 years ago

:shipit: