HAL STATUSFUNC should distinguish between warnings and errors

robotpy / robotpy-wpilib

Moved to https://github.com/robotpy/mostrobotpy

https://robotpy.github.io

Other

169 stars 59 forks source link

HAL STATUSFUNC should distinguish between warnings and errors #143

Closed virtuald closed 9 years ago

virtuald commented 9 years ago

This bug happens particularly when accessing the PDP. See http://www.chiefdelphi.com/forums/showthread.php?t=135145 for details.

virtuald commented 9 years ago

This bug may have happened because of https://github.com/robotpy/allwpilib/commit/7bdd91a058457db7b6d294137a8de26d47163e6d ... I can't see what artf4014 is though.

virtuald commented 9 years ago

@PeterJohnson can you look at the beta tracker and see what artf4014 is?

PeterJohnson commented 9 years ago

When there are multiple PCMs, reading the solenoid values from any PCM returns the value from PCM0. This is demonstrated in the attached sample programs which set PCM0 solenoid to Reverse and PCM1 solenoid to Forward. Reading both using GetAll returns 2 (reverse) for both PCM 0 and PCM1. It should return 2 for PCM0 and 1 for PCM1.

The PCM ID is not used when getting status in hal/ctre/PCM.cpp, so all status is from PCM 0

virtuald commented 9 years ago

Thanks!