search

robotpy / robotpy-wpilib

Moved to https://github.com/robotpy/mostrobotpy
https://robotpy.github.io
Other
169 stars 59 forks source link

Change minimum required version to Python 3.6 #613

Closed M1sterShad0w closed 4 years ago

M1sterShad0w commented 4 years ago

Continuation of #612 Based on #606

auscompgeek commented 4 years ago

Might be worth taking the time to clean up this condition too whilst we're here.

M1sterShad0w commented 4 years ago

Pretty sure we can just add python_requires=">=3.6" to setup() args and just remove the conditional.

auscompgeek commented 4 years ago

Yeah, I can't say I was ever really sure why we didn't just use python_requires here. We expect teams to install the pyfrc package on their computers after all, instead of installing wpilib directly.

On the other hand it does make some amount of sense for pyfrc to catch super-old versions of pip I guess.

virtuald commented 4 years ago

I believe when I first created these things, I didn't realize that python_requires existed or (more likely) it didn't exist at the time.

auscompgeek commented 4 years ago

python_requires is pretty old now; iirc it definitely existed at the time.