robots-from-jupyter / robotlab

Experiments in building installers for JupyterLab, Robot Framework and Friends
BSD 3-Clause "New" or "Revised" License
25 stars 3 forks source link

Back to 36 #36

Closed bollwyvl closed 5 years ago

bollwyvl commented 5 years ago

Like #35, but doesn't try to go after python 3.7.

The osx chromedriver for stable is up, so this might work....

datakurre commented 5 years ago

@bollwyvl I have no idea why "robotlab-tutorial" command fails on Windows. There is no visible error in logs. Would be able to figure out that one?

I try to fix those tests...

bollwyvl commented 5 years ago

Great, that fixed tutorial...

Were your saying you were going to take a look at the other tests? I can as well... When next at keyboard. Also is looks like some of the Screenshots are getting messed up... I Probably need to do some reorganization of the output directories.

On Mon, May 27, 2019, 23:22 Asko Soukka notifications@github.com wrote:

@bollwyvl https://github.com/bollwyvl I have no idea why "robotlab-tutorial" command fails on Windows. There is no visible error in logs. Would be able to figure out that one?

I try to fix those tests...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robots-from-jupyter/robotlab/pull/36?email_source=notifications&email_token=AAALCRENZ762M4LBISQ62MTPXSQO7A5CNFSM4HP6T4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWK3PEA#issuecomment-496351120, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALCRGUMKKSIIJDOZCBC7LPXSQO7ANCNFSM4HP6T4UA .

bollwyvl commented 5 years ago

Doing some work locally on this: a big reason we might be getting mysterious errors during acceptance is all of the new noarch:python packages from anaconda (they used to not distribute any). From the install log, these are certainly noarch: python:

installing: defusedxml-0.6.0-py_0 ...
installing: genson-1.1.0-py_0 ...
installing: parso-0.4.0-py_0 ...
installing: pytz-2019.1-py_0 ...
installing: strict-rfc3339-0.7-py_1 ...
installing: pygments-2.4.0-py_0 ...
installing: nbconvert-5.5.0-py_0 ...

I'll go ahead and build these, too, but this is getting a bit silly, and definitely starts to point at why my little constructor pre/post-processor will be a Good Thing To Open Source. I took a little detour to work some more of the model-based testing angle, and didn't do the testing/docs work we require to get stuff out the door, even though it's already quite useful. I'll push harder to get the azure/pypi/npm account stuff cleared up that's still blocking irobotframework (first email asking about that was sent from Helsinki :rofl:) and try to get that out!

bollwyvl commented 5 years ago

ok, built those, and got a clean build locally... :crossed_fingers: :neckbeard: :crossed_fingers:

datakurre commented 5 years ago

:-o on how hard this is...

I haven’t looked into tests yet :(

bollwyvl commented 5 years ago

:-o on how hard this is...

Yeah, it's not all :rose:s, that's for sure.

bollwyvl commented 5 years ago

Found a bad selector in robotframework-jupyterlibrary, seems good locally...

bollwyvl commented 5 years ago

Nope, that didn't do it... will have a look later...

bollwyvl commented 5 years ago

I'll take one :green_heart:!

datakurre commented 5 years ago

Replaced with https://github.com/robots-from-jupyter/robotlab/pull/41