search

robots-from-jupyter / robotlab

Experiments in building installers for JupyterLab, Robot Framework and Friends
BSD 3-Clause "New" or "Revised" License
25 stars 3 forks source link

Validate against SeleniumLibrary 4 #46

Closed bollwyvl closed 5 years ago

bollwyvl commented 5 years ago

We'll need to pin to <4 to get the release out.

datakurre commented 5 years ago

I cannot find any issues with SeleniumLibrary 4.0.0. I will make a pull for it.

datakurre commented 5 years ago

https://github.com/robots-from-jupyter/robotlab/pull/50

datakurre commented 5 years ago

The new behavior of Open Browser alias=something is very cool. It no longer opens new browser windows if one with that alias is already open. Working perfectly with robotkernel sticky selenium sessions.

bollwyvl commented 5 years ago

Ooooh! Thanks for trying it out! Sounds all ergonomic and stuff.

This raises the question of when we would want to drop the next release... Wait until 2019.10? Continuous delivery is fun and all...

On Tue, Sep 24, 2019, 13:40 Asko Soukka notifications@github.com wrote:

The new behavior of Open Browser alias=something is very cool. It no longer opens new browser windows if one with that alias is already open. Working perfectly with robotkernel sticky selenium sessions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/robots-from-jupyter/robotlab/issues/46?email_source=notifications&email_token=AAALCREKMXR5P4S6UPO42RTQLJGIXA5CNFSM4IY3JQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7PGH6Q#issuecomment-534668282, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALCRFDPN67NXZLSUGWAHTQLJGIXANCNFSM4IY3JQ2Q .

bollwyvl commented 5 years ago

Closed by #50

datakurre commented 5 years ago

How much fun it really is? 🙃I push a tag and the robot drafts the release? If everything is automated up to draft and even I could make that, then I could practise 2019.09.1

bollwyvl commented 5 years ago

Right it's great for us, but not so for users if we push a bad installer. CD should have some way of knowing if the deploy is broken, and then rolling back. Users will find/bring problems we can't even imagine, and it can be very hard to get a useful error report... It's more likely people just leave.

I guess we could initially mark them as pre-release (doesn't get shown by default)...

On Tue, Sep 24, 2019, 23:29 Asko Soukka notifications@github.com wrote:

How much fun it really is? 🙃I push a tag and the robot drafts the release?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/robots-from-jupyter/robotlab/issues/46?email_source=notifications&email_token=AAALCREMDTCAX3RALINESLDQLLLJ3A5CNFSM4IY3JQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7QPBMQ#issuecomment-534835378, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALCRF2UN3LD2APGVCK333QLLLJ3ANCNFSM4IY3JQ2Q .

datakurre commented 5 years ago

But isn’t it draft until we promote it?

And it yes, what I actually should do? Push a tag?

bollwyvl commented 5 years ago

Yes, we do have that manual step in place... So it's not quite CD. Maybe OCD.

If we want to go for it, we'd make a PR:

Getting there! I should make an issue for generating the release notes... It would be nice to have at least the updated/new package tables made from ground truth (what actually got installed). Heck, I'd like to have links to those changelogs, but that's not in the metadata at present (sadly).

We could also consider something like rever: https://github.com/regro/rever But it has many opinions.

On Wed, Sep 25, 2019, 09:05 Asko Soukka notifications@github.com wrote:

But isn’t it draft until we promote it?

And it yes, what I actually should do? Push a tag?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/robots-from-jupyter/robotlab/issues/46?email_source=notifications&email_token=AAALCRARTV67CN366K6BP3LQLNOYDA5CNFSM4IY3JQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7R2IOY#issuecomment-535012411, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALCRABHXSAGO3QIFK6XLTQLNOYDANCNFSM4IY3JQ2Q .

datakurre commented 5 years ago

Thanks for the details. 2019.10.0 fits for me :) I’ll try out those steps next week.

bollwyvl commented 5 years ago

Yeah we should probably split out a CONTRIBUTING.md, and formalize the process.

On Wed, Sep 25, 2019, 10:32 Asko Soukka notifications@github.com wrote:

Thanks for the details. 2019.10.0 fits for me :) I’ll try out those steps next week.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/robots-from-jupyter/robotlab/issues/46?email_source=notifications&email_token=AAALCRGPA5DG42H6WEQIT6DQLNY6JA5CNFSM4IY3JQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7SD3TQ#issuecomment-535051726, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALCRDTSOXKTEW4OREACO3QLNY6JANCNFSM4IY3JQ2Q .