search

robots-from-jupyter / robotlab

Experiments in building installers for JupyterLab, Robot Framework and Friends
BSD 3-Clause "New" or "Revised" License
25 stars 3 forks source link

Prepare for 2019.12.0 #59

Closed datakurre closed 4 years ago

bollwyvl commented 4 years ago

Go go go! How can I help?

On Wed, Dec 4, 2019, 17:37 Asko Soukka notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/robots-from-jupyter/robotlab/pull/59 Commit Summary

  • 57: jupyterlab 1.2.3

  • 57: widget manager

  • 57: robot version

  • 57: remove testability from local dev env (not packaged yet)

  • 57: more work on recipe

  • 57: add jupytext

  • 57: start working testability 0.0.15

  • 57: build testability, but not RIDE

  • fix some deprecated variable access syntax
  • Downgrade to robotframework 3.1.2
  • Upgrade to robotkernel 1.2rc1

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/robots-from-jupyter/robotlab/pull/59?email_source=notifications&email_token=AAALCRH4HAKPK7IS27GRHQLQXAWLTA5CNFSM4JVQKKEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6ETJEA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCRFUCBTV4QGJOCIOCKDQXAWLTANCNFSM4JVQKKEA .

datakurre commented 4 years ago

@bollwyvl Green! Help in drafting the release would be awesome!

bollwyvl commented 4 years ago

Looking good!

Help in drafting the release would be awesome!

What are you looking for? It doesn't seem like a bunch of narrative is required, as we'll hopefully end up pushing out something with some more final revs...

datakurre commented 4 years ago

I guess these are the major changes between 2019.9.0 and 2019.12.0

In addition, 2019.12.0 is compatible with RF 3.2a1 when manually upgraded after installation.

datakurre commented 4 years ago

Slightly related. OpenCV example for robotkernel fails currently at Binder, because of

import cv2

---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-2-c8ec22b3e787> in <module>
----> 1 import cv2

ImportError: libGL.so.1: cannot open shared object file: No such file or directory

I recall it has been working. Does that need something extra in Binder configuration nowadays?

https://github.com/robots-from-jupyter/robotkernel/tree/master/binder

datakurre commented 4 years ago

This should now be ready for merge.

bollwyvl commented 4 years ago

Ooh I should looks into the opencv thing... But merge if you're happy with it otherwise!

On Fri, Dec 6, 2019, 03:44 Asko Soukka notifications@github.com wrote:

This should now be ready for merge.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robots-from-jupyter/robotlab/pull/59?email_source=notifications&email_token=AAALCREFWS2LA327WPK3K2DQXIGGLA5CNFSM4JVQKKEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGDNRCA#issuecomment-562485384, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCREW6GHEW6J7IEY5DQTQXIGGLANCNFSM4JVQKKEA .

datakurre commented 4 years ago

@bollwyvl So what is really required to turn this into a release? 🤔 I could follow the steps we listed previously manually with the latest builds from this pull, but I assume that you already automated some parts of it?

I’d love to have a release that I would use myself to update the training materials for my RoboCon workshop. Then I’d have 100 % confidence on everything at the workshop. 🙏

bollwyvl commented 4 years ago

I'll try making a tag, and see what happens!

bollwyvl commented 4 years ago

https://dev.azure.com/robots-from-jupyter/robots-from-jupyter/_build/results?buildId=270

bollwyvl commented 4 years ago

I got rid of your previous draft (whoops): I don't know why it didn't start the tag build, but assume it would create a problem if it got all the way to the release stage and there was already something there. We should get some installers submitted as a draft, and then we just need to monkey with the release text.

Of course, we haven't tested this in some time, so who knows...

bollwyvl commented 4 years ago

well, it got to the release stage!

bollwyvl commented 4 years ago

and it's uploading...

bollwyvl commented 4 years ago

and they're in there! ...but with a janky auto-generated release message...

datakurre commented 4 years ago

@bollwyvl Thanks! So everything is automated, but somehow my tag didn’t trigger that.

I’ll try out the builds in following days!

datakurre commented 4 years ago
datakurre commented 4 years ago

All tested and looks good. Did you have any scripts to help with the release notes previously?

bollwyvl commented 4 years ago

So everything is automated, but somehow my tag didn’t trigger that.

I don't think draft tags made through the web ui get picked up by azure. I did a CLI git tag and git push --tags and it worked without any other interaction.

Did you have any scripts to help with the release notes previously?

nope, did it by hand. I guess we'd just copy paste, and maybe grab the listing from CI while its still available. It would be nice to do better, of course!

bollwyvl commented 4 years ago

mostly updated...

datakurre commented 4 years ago

Looking good. I added jupytext into new packages.

bollwyvl commented 4 years ago

Ahh, good catch.

On Sun, Dec 8, 2019, 23:23 Asko Soukka notifications@github.com wrote:

Looking good. I added jupytext into new packages.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robots-from-jupyter/robotlab/pull/59?email_source=notifications&email_token=AAALCRCCAIIIBMYBWBHVBELQXXB3DA5CNFSM4JVQKKEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGHZAYI#issuecomment-563056737, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCRFM6CTLSXIKVU7LY6LQXXB3DANCNFSM4JVQKKEA .

datakurre commented 4 years ago

@bollwyvl Found an issue. Jupytext Lab extensions is not available.

I had to install it manually with !jupyter labextension install jupyterlab-jupytext from Python notebook to make it available.

We should add that into build, but what would be proper way to install new extensions on top of RobotLab install? What is the proper way to activate the env from Window Cmd prompt? Or maybe "Terminal" from Jupyter Lab, but returned NPM error, because it could not find "node.exe" from path :thinking:

datakurre commented 4 years ago

Fixed jupyterlab-jupytext. Removed draft (after taking backup of notes). Pushed moved tag. Now waiting for the magic to happen.

datakurre commented 4 years ago

Almost. Help still required for testing Linux installer.

bollwyvl commented 4 years ago

Does the Sha match the calculated hash? That would be annoying if we couldn't rely on the pipeline to release the binaries we had actually tested...

On Mon, Dec 9, 2019, 17:23 Asko Soukka notifications@github.com wrote:

Almost. Help still required for testing Linux installer.

  • Windows installer ok
  • OSX installer ok
  • Linux seems corrupted for me (fails to unpack files after license questions)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robots-from-jupyter/robotlab/pull/59?email_source=notifications&email_token=AAALCRANOA6NISKEJHOWIE3QX3AN7A5CNFSM4JVQKKEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGK5L7I#issuecomment-563467773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCRFURR4UJ26HGZSUCVTQX3AN7ANCNFSM4JVQKKEA .

bollwyvl commented 4 years ago

Hm, just downloaded and ran without issue on Ubuntu 19.10. Heck, even the deskop icon worked (had to right click and say Allow Launching, but I'll take it). SHA sums matched up, so I'm pretty sure i tested what CI was putting down.

$> ~/Downloads$ sha256sum RobotLab-2019.12.0-Linux-x86_64.sh 
40dc50fe9d2a6604d39a48a6b63c9b96442e8087c65f58c4614e68fc44e192e9  RobotLab-2019.12.0-Linux-x86_64.sh
$> ~/Downloads$ more SHA256SUMS 
40dc50fe9d2a6604d39a48a6b63c9b96442e8087c65f58c4614e68fc44e192e9  RobotLab-2019.12.0-Linux-x86_64.sh
73ec3fbf60de2b5bc2158f5c32ae8cd7a9da07fcbdebde361f88893be5d490a4  RobotLab-2019.12.0-MacOSX-x86_64.sh
18183b31430d00cd30e639f5d8245e134a54c43ec9c28eea7acc65f924dd8cae  RobotLab-2019.12.0-Windows-x86_64.exe
$> ~/Downloads$ bash RobotLab-2019.12.0-Linux-x86_64.sh -fbp /tmp/robotlab-2019.12.0
PREFIX=/tmp/robotlab-2019.12.0
...
Preparing transaction: done
Executing transaction: done
Making RobotLab shortcut in $HOME...
 ~
Shortcut created...
{'args': '',
 'description': 'Launch RobotLab in Firefox in your $HOME',
 'folder': '',
 'full_script': '/tmp/robotlab-2019.12.0/lib/python3.6/site-packages/robotlab/launch.py',
 'icon': '/tmp/robotlab-2019.12.0/lib/python3.6/site-packages/robotlab/icons/lab.ico',
 'name': 'RobotLab',
 'script': '/tmp/robotlab-2019.12.0/lib/python3.6/site-packages/robotlab/launch.py',
 'target': '~/Desktop/RobotLab.desktop'}
installation finished.
datakurre commented 4 years ago

@bollwyvl Then it was just me. I will check the hash.

Maybe this means that 2019.12.0 is finally ready 😅

datakurre commented 4 years ago

@bollwyvl Confirmed that my Linux-issue was my own mistake. Sorry for the false flag, but thanks for testing!

I will release 2019.12.0 :tada: :rocket:

bollwyvl commented 4 years ago

Yay!

On Mon, Dec 9, 2019, 23:54 Asko Soukka notifications@github.com wrote:

@bollwyvl https://github.com/bollwyvl Confirmed that my Linux-issue was my own mistake. Sorry for the false flag, but thanks for testing!

I will release 2019.12.0 🎉 🚀

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robots-from-jupyter/robotlab/pull/59?email_source=notifications&email_token=AAALCRHSPFN5RBCGIE4TO5LQX4OH3A5CNFSM4JVQKKEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGNOP6I#issuecomment-563800057, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCRG342GLZJ2RIKS4I2LQX4OH3ANCNFSM4JVQKKEA .