Structural clean-up - Githubissues

robotsorcerer / Savitzky-Golay

Computes the Savitzky-Golay Filter coefficients.

Apache License 2.0

104 stars 32 forks source link

Structural clean-up #2

Closed catskul closed 8 years ago

catskul commented 8 years ago

Just did some structural adjustments for my own sake while playing with the code, and figured I'd submit them back in case you find them useful:

Removed using namespace in header file to avoid accidental namespace pollution
Minimized header includes
Refactored globals into function parameters
Separated example code into separate file
Moved image files to separate dir to clean up the include dir

robotsorcerer commented 8 years ago

This is awesome. Could you write a helper function in the savgol.cpp file that shows how the frame size, polynomial order and range on inputs can be set from the command line? So that by calling ./savgol --help or ./savgol -h from the command line, the user is shown how the parameters are set.

I added a Contribution.md file to the master to aid future developers. You may add this to your local branch before your next push. Thanks!

Weldone!

catskul commented 8 years ago

Glad to help!

I don't have the time to make other changes at the moment, but this pull request should be independent anyway. I think this is ready for merge.

robotsorcerer commented 8 years ago

No worries, @catskul.