Closed ashleyj closed 9 years ago
Any way to chose the OS version as well? Also, not all simulators may be installed as far as i understood. Is it possible to pass parameters to a task? I think that'd be a better option. E.g. have one simulator task that takes the simulator id as a parameter.
1) Yes the OS version can be added, but I thought it'd make the task names too long
2) You're right all these simulators won't exist on all systems, but they will for anyone running XCode 6 with sdk 8.0 (default).
I guess it's probably better to build this list dynamically with DeviceType.listDeviceTypes(), but the unpack of home can be quite cumbersome and might hang gradle unnecessarily when doing a 'gradle tasks' -- what do you think ?
3) As far as I can see (I'm no gradle expert) there's no way to send arguments to a Task.
1) ya, that's true. If we omit the OS version we have to at least define how the version is chosen (e.g. latest)
2) ack, folks need XCode 6 anyways. I agree that unpacking might be a bit unwidely. A validity check would probably suffice.
3) bummer On Sep 29, 2014 12:13 PM, "Ashley" notifications@github.com wrote:
1) Yes the OS version can be added, but I thought it'd make the task names too long
2) You're right all these simulators won't exist on all systems, but they will for anyone running XCode 6 with sdk 8.0 (default).
I guess it's probably better to build this list dynamically with DeviceType.listDeviceTypes(), but the unpack of home can be quite cumbersome and might hang gradle unnecessarily when doing a 'gradle tasks' -- what do you think ?
3) As far as I can see (I'm no gradle expert) there's no way to send arguments to a Task.
— Reply to this email directly or view it on GitHub https://github.com/robovm/robovm-gradle-plugin/pull/22#issuecomment-57141060 .
Added code to force choice of the latest version Added error message if SIM doesn't exist
I modified to be able to specify the device and sdk version by the project properties. Please review #23.
Guys, which of #22 and #23 should I merge? Are they mutually exclusive or do they build on each other?
I think it's a better option to have the device type specified as properties rather than having tasks for each. So that's what #23 does IIUC? But does it build on #22?
@ashleyj, please reformat your code using the RoboVM formatter.xml
. You can find it in the root of the robovm repo. If you don't use Eclipse just make sure you change all tabs to 4 spaces in the Java files. Thanks!
Also, @jtakakura could you please add a section to README.md on how to specify these properties from the command line when invoking Gradle? Thanks!
I'd also go with property based selection of the device. The two PRs do not build on each other afair. My original changes would simply chose the "best" device (first device found with the latest SDK).
On Mon, Oct 6, 2014 at 11:53 AM, Niklas Therning notifications@github.com wrote:
Guys, which of #22 https://github.com/robovm/robovm-gradle-plugin/pull/22 and #23 https://github.com/robovm/robovm-gradle-plugin/pull/23 should I merge? Are they mutually exclusive or do they build on each other?
I think it's a better option to have the device type specified as properties rather than having tasks for each. So that's what #23 https://github.com/robovm/robovm-gradle-plugin/pull/23 does IIUC? But does it build on #22 https://github.com/robovm/robovm-gradle-plugin/pull/22?
@ashleyj https://github.com/ashleyj, please reformat your code using the RoboVM formatter.xml. You can find it in the root of the robovm repo. If you don't use Eclipse just make sure you change all tabs to 4 spaces in the Java files. Thanks!
Also, @jtakakura https://github.com/jtakakura could you please add a section to README.md on how to specify these properties from the command line when invoking Gradle? Thanks!
— Reply to this email directly or view it on GitHub https://github.com/robovm/robovm-gradle-plugin/pull/22#issuecomment-57995810 .
Merge #23
On 6 October 2014 19:53, Niklas Therning notifications@github.com wrote:
Guys, which of #22 https://github.com/robovm/robovm-gradle-plugin/pull/22 and #23 https://github.com/robovm/robovm-gradle-plugin/pull/23 should I merge? Are they mutually exclusive or do they build on each other?
I think it's a better option to have the device type specified as properties rather than having tasks for each. So that's what #23 https://github.com/robovm/robovm-gradle-plugin/pull/23 does IIUC? But does it build on #22 https://github.com/robovm/robovm-gradle-plugin/pull/22?
@ashleyj https://github.com/ashleyj, please reformat your code using the RoboVM formatter.xml. You can find it in the root of the robovm repo. If you don't use Eclipse just make sure you change all tabs to 4 spaces in the Java files. Thanks!
Also, @jtakakura https://github.com/jtakakura could you please add a section to README.md on how to specify these properties from the command line when invoking Gradle? Thanks!
— Reply to this email directly or view it on GitHub https://github.com/robovm/robovm-gradle-plugin/pull/22#issuecomment-57995810 .
Ok, merged #22. Thanks for the effort though. ;-)
Added the following tasks to support the new iOS simulators in XCode 6:
launchiPad-2Simulator - iPad-2 launchiPad-AirSimulator - iPad-Air launchiPad-RetinaSimulator - iPad-Retina launchiPhone-4sSimulator - iPhone-4s launchiPhone-5Simulator - iPhone-5 launchiPhone-5sSimulator - iPhone-5s launchiPhone-6-PlusSimulator - iPhone-6-Plus launchiPhone-6Simulator - iPhone-6 launchResizable-iPadSimulator - Resizable-iPad launchResizable-iPhoneSimulator - Resizable-iPhone
The original tasks still exist and function correctly: createIPA launchIOSDevice launchIPhoneSimulator launchIPadSimulator