search

robovm / robovm-gradle-plugin

RoboVM Gradle plugin
45 stars 24 forks source link

Set skipInstall to false to avoid debug flag. For discussion, not merge #8

Closed walle closed 10 years ago

walle commented 10 years ago

When I tried to upload my IPA file to Apple I got a verification error non public symbols in exc_server. I tracked it down do the -lrobovm-debug flag robovm uses when compiling (clang++).

I installed a local version of the gradle plugin (with skipInstall=false) and used it for building the IPA and it passed.

The question is though, what is the valid thing to do here, should the skipInstall variable be true, and something in robovm needs to be changed? Or is this just a bug and this pull request fixes it?

I don't know enough about robovm to make that call, started using it this week, therefor this pull request and discussion.

Looking forward to your response!

Info about the commit

The flag ´-lrobovm-debug´ makes the validation service fail when trying to upload the IPA to Apple. Fails with message "non public symbols in exc_server"

Flag is set if skipInstall is true at: https://github.com/robovm/robovm/blob/36b4fd955a8acbae0459550d324c5c70d996ee6c/compiler/src/main/java/org/robovm/compiler/target/AbstractTarget.java#L98

jtakakura commented 10 years ago

It's a bug. I merged your pull request. Thanks.

walle commented 10 years ago

Great, thanks!

Does this mean I can remove my local repository dependence and start using the plugin you supply, or will this end up in the next release?

jtakakura commented 10 years ago

I plan to release at the same time of new robovm(maybe 0.0.10) release.

walle commented 10 years ago

Great!

Another thing, when I used my local repository to build the plugin I got an error. Because of the variables in uploadArchives. Eg. sonatypeUsername.

My solution was to simply remove the task. But perhaps a check to see if they exist or not, or read them from the cli if they are needed would be a better solution?

As it is now new developers might be confused about how to be able to build the plugin. Should I open a new issue for this?

jtakakura commented 10 years ago

Thank you for your suggestion. Please open new issue.

Thanks, Junji