search

robproject / fsjd

Git External Diff machinery for Frappe Framework JSON schema
MIT License
7 stars 2 forks source link

Inequal table and tree line no's #12

Open robproject opened 5 months ago

robproject commented 5 months ago
  1. The line number in the table diff is different than the tree diff.
  2. The end node of the path in the table is different than the end node tree diff.

Tree diff: image Table diff: image

robproject commented 1 month ago

this may be fixed with latest commit, need to confirm. Addition was being pulled from base instead of head. If this is the case, every line number for an addition may be off by one since the base will always be pointing to the position where the addition doesn't yet exist.