search

robrich / gulp-match

Does a vinyl file match a condition?
MIT License
23 stars 9 forks source link

File extension globs quit working #1

Closed yocontra closed 10 years ago

yocontra commented 10 years ago

Super weird, globs like *.styl quit matching. Had to switch to using /\.styl$/ which is a lot uglier.

robrich commented 10 years ago

By quit working, do you mean it worked in a previous version and doesn't now or do you mean that it works for a while and then stops? What's an example vinyl file you pass in? (e.g. does **/*.styl match?)

yocontra commented 10 years ago

@robrich *.ext has always worked in the past, just recently started a new project and it does not seem to work.

robrich commented 10 years ago

Solved with https://github.com/robrich/gulp-match/commit/644bb94f51b547a04a743c68b0cd8dad19b7d247. I believe the true cause is that either minimatch is no longer matching partial paths or more likely vinyl-fs is now passing full paths. Either way, special-casing *.ext solved the concern.