search

robrich / ternary-stream

A ternary stream: conditionally control the flow of stream data
MIT License
36 stars 5 forks source link

Ternary-Stream breaking on Node versions less than 6 #12

Closed grunj closed 5 years ago

grunj commented 5 years ago

The latest dependency upgrade in the PR https://github.com/robrich/ternary-stream/pull/11 is breaking on Node versions <6 (not supporting ES2015 syntax). I think @robrich has already addressed this here in the PR merge Originally posted by @robrich in https://github.com/robrich/ternary-stream/pull/11#issuecomment-512540816

See if you can revert it and release it as a major version upgrade please.

grunj commented 5 years ago

Issue details: gulp-if(~2.0.1) -> ternary-stream -> merge-stream -> index.js:3 (https://github.com/grncdr/merge-stream/blob/master/index.js#L3) is using es2015 syntax. For builds on versions <6 this throws SyntaxError: Unexpected token {

Screenshot 2019-07-18 at 15 09 56

robrich commented 5 years ago

Good catch. I need to patch upgrade dependencies back down, and major bump for these dependencies. I mistakenly assumed officially supported node versions were all I needed to worry about. Fail on me.

robrich commented 5 years ago

Published 2.1.1 that reverts the dependency version bumps so it'll work on node < 6. For modern node, published 3.0.0, and I'll update gulp-if in a minute.

grunj commented 5 years ago

Thanks for the quick turnaround.