robrichards / xmlseclibs

A PHP library for XML Security
BSD 3-Clause "New" or "Revised" License
388 stars 181 forks source link

Add option to use template excluding whitespace #143

Open JD-Robbs opened 7 years ago

JD-Robbs commented 7 years ago

As discussed in #77, this PR adds an optional configuration flag (excludeWhiteSpace) which ensures that the signature validates in .NET.

Feel free to amend the naming/implementation (e.g., you may not want this in the constructor) as you see fit, but it would be great to see something like this included in the library as I could find no other way to ensure my signatures can be validated in .NET.

I wasn't so sure about the coding style - sometimes, I saw argument assignments with spaces and sometimes without. Hence, I just went with whatever I saw the most often.

Cheers, JD