search

robrichards / xmlseclibs

A PHP library for XML Security
BSD 3-Clause "New" or "Revised" License
387 stars 181 forks source link

Test for Potential Vulnerability VU#475445? Issue #163 #164

Closed gfaust-qb closed 6 years ago

gfaust-qb commented 6 years ago

As @runcoach mentioned in #163 I added a test for it.

It fails in PHP7 (not in PHP7.1) this seems to be an issue with travis-ci, PHP 7 and the used Version of PHPUnit.

(It already failed when I just forked it - in my opinion it is a problem of travis and the used version of phpunit)

A solution could be, not to use the provided versions of phpunit and to add own dependencies by composer.

gfaust-qb commented 6 years ago

This is not the complete test at the moment, it only demonstrates that an later added comment will not be verified and throws an Exception instead of returning false when validateReference() is called.